Update R geoscience packages

utoronto-2i2c / jupyterhub-deploy

Demo JupyterHub deployment for University of Toronto

BSD 3-Clause "New" or "Revised" License

3 stars 4 forks source link

Update R geoscience packages #116

Closed choldgraf closed 2 years ago

choldgraf commented 2 years ago

This is a re-opening of #101 , because the image build failed and so we reverted it from before.

We should:

[x] Build the image locally, confirm that it builds, and push to the staging hub
[ ] Confirm that it works w/ the instructor, by making sure that this notebook works: https://jupyter.utoronto.ca/hub/user-redirect/git-pull?repo=https%3A%2F%2Fgithub.com%2Fhhwagner1%2FBIO311_Labs&urlpath=tree%2FBIO311_Labs%2F&branch=main
[x] Merge this, and then merge to prod

mostly addresses https://github.com/2i2c-org/pilot-hubs/issues/697

GeorgianaElena commented 2 years ago

I believe the sf package install issue was because of conda installing the latest version of libgdal and gdal as a dependency of ones of the pkgs listed in environment.yaml.

Anyway, installing the R packages before the Python ones, solves this situation and it improves the caching of the R pkgs install, which takes forever.

@choldgraf, if Build Image is green, do you want to merge this, so that the image gets pushed and deployed to staging, then ask the instructor if everything looks good?

choldgraf commented 2 years ago

@GeorgianaElena good call! (and thanks for debugging that install issue, you are a wizard!)

I just went ahead and merged https://github.com/utoronto-2i2c/jupyterhub-deploy/pull/119 and once that is happy (aka I don't have to revert), I will merge this one into staging and we can test it out 👍

edit: argh it looks like the build is not happy :-/ though the errors look vaguely like they aren't related to this PR? I will try re-running

choldgraf commented 2 years ago

wohooo builds are happy, so I am merging!