search

utra-robosoccer / soccer-embedded

Collection of embedded programs for an autonomous humanoid soccer robot
http://utrahumanoid.ca
32 stars 8 forks source link

PeripheralInstances: fix missing SystemConf.h include #167

Closed rfairley closed 5 years ago

rfairley commented 5 years ago

Needed as PeripheralInstances.cpp uses symbols UART_HANDLE_* which are defined in SystemConf.h. Would not build today otherwise; must have got lucky with the linker before.

tygamvrelis commented 5 years ago

This should be there through the chain of includes actually—could you retry with a clean build and let me know what happens?

rfairley commented 5 years ago

Yes - works after a clean build without the include. Though, I think it should still be added, agreeing with https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes (paragraph beginning with You should include).

tygamvrelis commented 5 years ago

Thanks for the link, I agree with that. Another thing to purge...

rfairley commented 5 years ago

Yeah, another maintenance task I think