search

utra-robosoccer / soccer-embedded

Collection of embedded programs for an autonomous humanoid soccer robot
http://utrahumanoid.ca
32 stars 8 forks source link

tidy ups to SystemConf #175

Closed rfairley closed 5 years ago

rfairley commented 5 years ago

Tidy ups to SystemConf. Removes/adds includes where necessary.

Requires #173 before merging.

rfairley commented 5 years ago

List of files still using systemconf:

$ git grep SystemConf | grep -v docs
Common/app/PeripheralInstances.cpp:#include "SystemConf.h"
Common/app/freertos.cpp:#include "SystemConf.h"
Common/component/MPU6050/MPU6050.cpp:#include "SystemConf.h"
Common/include/HalI2CInterface.h:#include "SystemConf.h"
Common/include/SystemConf.h:  * @file    SystemConf.h
Common/include/SystemConf.h:outside of the SystemConf.h and SystemConf.cpp files . A new flag should
Common/include/SystemConf.h:#error "SystemConf error: invalid build configuratio n! Must define only one of STM32F446xx or STM32F767xx."
Common/include/UartInterface.h:#include "SystemConf.h"
Common/include/dsp.h:#include "SystemConf.h" // Need to include this before arm_ math                                                                             Robot/Src/F4/usart.cpp:#include "SystemConf.h"
Robot/Src/F7/usart.cpp:#include "SystemConf.h"
tygamvrelis commented 5 years ago

@rfairley Need a review on this?

rfairley commented 5 years ago

Yeah, thanks, this is ready for review. Was originally going to try and decouple SystemConf here, but we'll do that as a separate task in #177.

tygamvrelis commented 5 years ago

The changes look fine and Travis builds 😄

rfairley commented 5 years ago

:+1: merging this. Should not introduce any secondary include dependencies.