Migrates to google.golang.org/protobuf aka protobuf-v2

bullgare commented 3 years ago

Comments/questions/things to discuss as I see them:

go_package is mandatory now, so it is added to every integration test.
source_relative option is used almost everywhere in tests, as otherwise it generates unexpected paths (not related to clay though, as this path is being passed by protoc itself afaiu); source_relative option was added to clay to fit other plugins.
I needed to copy a lot of code from internal packages of "github.com/grpc-ecosystem/grpc-gateway/v2" to "cmd/protoc-gen-goclay/third-party". Not ideal, but I don't see other options so far. Maybe I could remove more files there, but I tried to keep it as simple as possible (it will also be easier to sync in the future). Please let me know what you think of it.
It is possible to add protobuf-v1 compatibility to pb.goclay.go, we just need to revert this commit - https://github.com/bullgare/clay/pull/1/commits/2e88e37d25f4286734c444629bc58b517a66a8b1. If you think we need it, I can do it.
I updated the example, hope, it's okay. For me it seems more clear to someone who sees this for the first time, but please share your opinion.
Maybe it's worth it to call it "clay/v3", wdyt?

bullgare commented 3 years ago

@utrack, @doroginin, @mwf could you please take a look?

utrack commented 3 years ago

Great stuff, thanks a lot! It's definitely worth it to cook up a new major version.

utrack / clay