utsaslab / crashmonkey

CrashMonkey: tools for testing file-system reliability (OSDI 18)
Apache License 2.0
193 stars 31 forks source link

Added ACE adapter for XFSTest #133

Closed raghavan-arvind closed 5 years ago

raghavan-arvind commented 5 years ago

Adds an XFSTest adapter for ACE so that we can generate test cases in the XFSTest format.

Manually verified that the below files (in which all supported instructions appear at least once) all generate valid and passing xfstests:

code/tests/seq1/j-lang-files/j-lang255 code/tests/seq1/j-lang-files/j-lang308 code/tests/seq1/j-lang-files/j-lang181 code/tests/seq1/j-lang-files/j-lang37
code/tests/seq1/j-lang-files/j-lang316 code/tests/seq1/j-lang-files/j-lang189 code/tests/seq1/j-lang-files/j-lang191 code/tests/seq1/j-lang-files/j-lang94
code/tests/seq1/j-lang-files/j-lang254 code/tests/seq1/j-lang-files/j-lang322 code/tests/seq1/j-lang-files/j-lang311 code/tests/seq1/j-lang-files/j-lang168 code/tests/seq1/j-lang-files/j-lang266 code/tests/seq1/j-lang-files/j-lang144 code/tests/seq1/j-lang-files/j-lang51
code/tests/seq1/j-lang-files/j-lang240

in ace/, running:

python2 xfstestAdapter.py -b base_xfstest.sh -t -p -n 001

will create /001 and /001.out

vijay03 commented 5 years ago

LGTM! @jayashreemohan29?

raghavan-arvind commented 5 years ago

Added!

On Wed, Oct 2, 2019 at 5:29 PM Jayashree Mohan notifications@github.com wrote:

@jayashreemohan29 requested changes on this pull request.

Please add the commands to run the adapter in the Ace Readme

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/utsaslab/crashmonkey/pull/133?email_source=notifications&email_token=AGPW36URE5AGHCXTQRIYYVDQMUOEXA5CNFSM4IWLEFE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGWSZCY#pullrequestreview-296561803, or mute the thread https://github.com/notifications/unsubscribe-auth/AGPW36VCLZTL3MPDMOMTIVTQMUOEXANCNFSM4IWLEFEQ .