Compiling Pebbles for MacOSX

utsaslab / pebblesdb

The PebblesDB write-optimized key-value store (SOSP 17)

BSD 3-Clause "New" or "Revised" License

506 stars 99 forks source link

Closed jayashreemohan29 closed 7 years ago

vijay03 commented 7 years ago

@jayashreemohan29 why is this closed? we need to merge the commits to master

jayashreemohan29 commented 7 years ago

I just committed the changes in Memory barrier. I thought of creating a PR after that

vijay03 commented 7 years ago

Ah, are you thinking of two PRs one for g++4 and one for Mac OSX? Otherwise we can just rename and use this PR.

jayashreemohan29 commented 7 years ago

No, I thought my new commit wouldn't reflect in this PR. And I'll end up creating two. Didn't realize we could use the old one.

vijay03 commented 7 years ago

Alright, can you rename this existing PR and I'll merge it?

jayashreemohan29 commented 7 years ago

Done. Bloom filter tests run fine on my system.