search

utsuboco / r3f-perf

Easily monitor your ThreeJS performances.
https://codesandbox.io/s/perlin-cubes-r3f-perf-wtp9t?file=/src/App.js
MIT License
603 stars 23 forks source link

DependencyNotFoundError #1

Closed simonghales closed 3 years ago

simonghales commented 3 years ago

The issue:

When installing r3f-perf and importing the component, the following error occurs:

DependencyNotFoundError

Could not find dependency: '@react-icons/all-files' relative to '/node_modules/r3f-perf/dist/r3f-perf.cjs.development.js'

Example Codesandbox: https://codesandbox.io/s/upbeat-pasteur-mvx5d?file=/src/App.js

I suspect that the dev dependencies aren't being installed by default when the package is downloaded, but I could be wrong. Happy to have a closer look tomorrow (it's 2am so I need to get some sleep.)

Cheers

RenaudRohlinger commented 3 years ago

@simonghales Oops indeed I forgot. It's fixed with 0.3.2!

https://codesandbox.io/s/clever-butterfly-ksk62?file=/public/index.html

simonghales commented 3 years ago

Great, thanks for the speedy resolution :) looks good!