fix: simplify Html component

utsuboco / r3f-perf

Easily monitor your ThreeJS performances.

MIT License

573 stars 21 forks source link

Closed alexandernanberg closed 2 years ago

alexandernanberg commented 2 years ago

What

Enable jsx runtime
Simplify logic in <Html> (remove babel generated code + move React root creation inside effect)

Everything seems to work the exact same way in the example app, not sure if there are more things to test

RenaudRohlinger commented 2 years ago

Awesome, thank you!

Also, the build demo was breaking because it needed React in the imports. Not sure how babel handles that 😄

RenaudRohlinger commented 2 years ago

Update:

Vite actually needed @vitejs/plugin-react in order to work properly. So thank you very much for jsx runtime 👍

alexandernanberg commented 2 years ago

Alright, yeah with the jsx runtime you shouldn't need to import React anymore