search

utterance / utterances

:crystal_ball: A lightweight comments widget built on GitHub issues
https://utteranc.es
MIT License
8.68k stars 566 forks source link

Reactions on main post #340

Open arunvelsriram opened 3 years ago

arunvelsriram commented 3 years ago

Related issue: #188

This is a work in progress PR. Lot of things to implemented/handled.

Done:

  1. Show/submit reactions for existing issue
  2. Show/submit reaction on new issue created by first comment
  3. Show total reaction count

Pending things on top of my head:

  1. Fix error when reacting on new issue created through a reactions button
  2. Fix issue with updating the reaction count
  3. Disable when user is not logged in
  4. UI for showing "signin to react"
  5. Style for various themes

Currently it looks like this:

Screenshot 2020-06-15 at 12 03 43 AM
arunvelsriram commented 3 years ago

I have pushed changes for:

  1. Fix error when reacting on new issue created through a reactions button
  2. Fix issue with updating the reaction count
  3. Disable when user is not logged in

For, 4. UI for showing "signin to react": Just a thought - there is a "Sign in to comment" already, we could rename it to "Sign in" and avoid creating another Sign in button. If you think a separate Sign in button is required for reactions, I would need your input on where to place the the Sign in button.

For, 5. Style for various themes: I tested this. It appears to be working fine.

New screenshot:

Screenshot 2020-06-16 at 12 36 51 AM
arunvelsriram commented 3 years ago

The reaction buttons are getting wrapped to a new line unevenly and there is some issue with border as well in small screens. Let me know you thoughts on handling this.

Screenshot 2020-06-16 at 12 43 00 AM
techboyg5 commented 3 years ago

I think that the reactions button should be in a popup menu on the far right side of the line that says "X Comments - powered by utteranc.es".

brennerm commented 3 years ago

@arunvelsriram Will you continue working on this topic? I'd really like to see this feature coming.

arunvelsriram commented 3 years ago

Functionality wise everything is covered as far as I remember. There are UI improvements and we need to decide about the Sign In button.

I don't have much experience in UI development. Please fee l free to add improvements on top of this.

willianantunes commented 3 years ago

@arunvelsriram, you did fantastic work with this feature! It works like DISQUS. Pretty cool!

Is the Sign In button issue a must-have requirement? Can this PR be merged without this, and then another PR be created to solve the button UX, if required? Emoji Reactions can be enabled as a "beta" feature, let's say through the JS.