search

utterance / utterances

:crystal_ball: A lightweight comments widget built on GitHub issues
https://utteranc.es
MIT License
8.68k stars 566 forks source link

add new theme classic-dark #463

Open rpetit3 opened 3 years ago

rpetit3 commented 3 years ago

Hello!

Here's a new theme that is based off 'github-dark' to match Github's current Dark Mode.

We had a brief discussion (https://github.com/utterance/utterances/issues/462) and I realize the "github-dark" theme will be updated when Primer is updated. This made me think it might be useful to create a separate theme, so that changes to Primer or GitHub's Dark Mode won't affect the theme.

I named it dark-mood, and I'm not attached to it, so if you want to rename go for it!

Please let me know if anything else is needed.

Thank you!

Here's a screenshots, from my local build: dark-mood dark-mood2

jdanyow commented 3 years ago

@rpetit3 I like the idea of keeping the original dark theme around for folks who don't want to adopt GitHub's official dark theme. I'll revisit this PR once Primer lands https://github.com/primer/css/pull/1131.

What do you think of Classic Dark for the theme name?

rpetit3 commented 3 years ago

Classic Dark works perfectly! I'll update the PR

rpetit3 commented 2 years ago

Hi @jdanyow

If you have a moment, would love to get your thoughts.

Thank you!

rpetit3 commented 2 years ago

@jdanyow - Please me know if anything is needed on my end.

rpetit3 commented 2 years ago

@jdanyow I think I'm going to go ahead and abandon this PR.

Utterances is great cheers!