search

utterworks / fast-bert

Super easy library for BERT based NLP models
Apache License 2.0
1.86k stars 341 forks source link

The current BertClassificationPredictor has a bug in model_path parameter #216

Closed markovivl closed 4 years ago

markovivl commented 4 years ago

The current BertClassificationPredictor has a bug in model_path parameter when it tries to create tokenizer from AutoTokenizer. It would be good to fix it but also let an option to provide a custom tokenizer.

markovivl commented 4 years ago

Mainly, the bug is that AutoTokenizer expects a str object, and is provided a PathIx object.

aaronbriel commented 4 years ago

Why are you passing it a Pathlx object instead of a str?

markovivl commented 4 years ago

You are right, it is probably my fault and not the library, but in my defense I was running the sample notebook when the error happened. Sorry for the issuing.

aaronbriel commented 4 years ago

No worries! The notebooks may indeed be in need of some attention.