Closed adyba closed 8 years ago
@adyba Thanks for using plugin and valuable suggestion, i will make those changes.
@adyba updated the directive with only angular, removed jquery dependency and cleaned,organized the code. made latest release 3.0.0 which is available on bower.
Hi, this module is a perfect fit for Ionic. After small changes I'm using it in one my project and it works like a charm. But there are two small complains that can be solved in about 5 LOCs.
$
forangular.element
all the code is no more dependent on jQuery.<img>'s
without all the wrappers. Thus the very end of the link function to be changed to mimic the deprecated (?)replace:true
directive behavior. Simply<ng-letter-avatar data="Zimbra"></ng-letter-avatar>
should compile just into
<img src="data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDo..." style="">
Any of those changes should not harm your project, but Im not aware of the whole context. Do you want me to PR my changes or I should just fork into a
ngletteravatar for Ionic
?