search

uttesh / ngletteravatar

directive for the letter avatar for the given string like gmail, first letter of the given data will be the avatar .
http://uttesh.github.io/ngletteravatar/
MIT License
136 stars 36 forks source link

Border radius should be in percent? #8

Closed josteinhanssen closed 8 years ago

josteinhanssen commented 8 years ago

I suggest changing the default setting for the border-radius to: 'border-radius:50%;'. This way it will always be a completly round shape.

The way it is now, it renders as squares with rounded corners when the size gets bigger (ie 120x120).

uttesh commented 8 years ago

@josteinhanssen thanks for the input, we will update that in next release.

oglematt commented 8 years ago

@uttesh, When can we expect to see this change? I'd be happy to put it together in a PR, but it's quite literally a single line change from 30px to 50%. If you'd like me to make the adjustment and submit a PR, please let me know. Thanks!

uttesh commented 8 years ago

@oglematt thanks , that property is already updated in library, may be i missed to update in the read me page/file, i will update now.

oglematt commented 8 years ago

@uttesh, Thanks for the reply. I see that it's on master, but it doesn't appear to have made it to a release. I used bower and that shows that the border radius is still set to 30% and the latest release (4.0.0) also shows 30%.

uttesh commented 8 years ago

oh thanks @oglematt i will update the bower and npm libs

oglematt commented 8 years ago

@uttesh, Fantastic. Thank you!