utubo / firefox-simple_gesture

🦊An add-on that adds simple touch gestures for Firfox for Android. Sorry, I only check issues sometimes.
https://addons.mozilla.org/ja/firefox/addon/simple-gesture/
Other
29 stars 1 forks source link

Option for disable click on toast or hide toast timer #82

Closed LET33T37 closed 7 months ago

LET33T37 commented 8 months ago

so we can use double tap to open multiple links(close to or in the toast showing area) in background more quickly, no need to waitting the toast disappear.

utubo commented 8 months ago

ok. I'm busy right now but I think I can do it by the end of this month.

utubo commented 7 months ago

I released option of toast position.

If you want disable the toast in a local url only, try this custom gesture.

if (location.href === 'local url here') {
  for (let target = SimpleGesture.target; !!target; target = target.parentNode) {
    if (target.href) {
      SimpleGesture.open(target.href, { active: false });
      break;
    }
  }
} else {
  SimpleGesture.doCommand('openLinkInBackground');
}
LET33T37 commented 7 months ago

Tested v3.10, new options didnot fix the problem imo. Problaly a misunderstanding here because the title edited by me, sry.

Toast is needed and i just want to disable the "switch to new tab" when trying to open other links under the toast. Change toast positon didnot make it better on pages contain many links(eg. reddit/inoreader/forums)

Or a option can set a shorter time to make toast hide much quick.

utubo commented 7 months ago

You can scroll, hide the toast or change the position of the toast so that you do not click the toast.

I do not want to complicate the options.

The requirement to click on a link covered with toast seems too specific.

reddit/inoreader/forums

Please write the url exactly. Is that page not scrollable? (If I try that page maybe I will change my mind.)

I tried it at Hucker News ( https://news.ycombinator.com/ ) and didn't find it inconvenient. (It does flicker because of the api... )

Perhaps it would be better to have it at the top, like a command display, rather than having toast-covered links that are clickable.

LET33T37 commented 7 months ago

Ok, i got ur point. im not a dev and it is just a suggestion, not a request. Because sometimes gestures not work well on my phone(about 1/5 chance it wont be triggered) so hide toast isnot a option for me. These pages r scrollable and of cource i can scroll it like i can wait a tiny time until the toast disapear but this is a addition scroll/wait can be avoid imo.

This is a "open link in background toast", i dont get it y it need to be clickble for switch to new tab?

utubo commented 7 months ago

Thanks for sharing the details with me👍 How about something like this? PSX_20240122_150012

If you use FF nightly, you can try https://github.com/utubo/firefox-simple_gesture/releases/download/v3.11/simple-gesture.xpi and set toast position "top", Background of "Display Command" is #0005

utubo commented 7 months ago

v3.11 is released

LET33T37 commented 7 months ago

test new version this morning, it work perfectly, thank you so much.

ps: i tried to sign in for comments several times but always got connection timeout error (local dns issue) btw im using fennec(fdroid version) so i can't install ext from here.

utubo commented 7 months ago

Thank you for your time due to my persistence.🙏

Glad you like it.