utwente-fmt / ltsmin

The LTSmin model checking toolset

http://ltsmin.utwente.nl

BSD 3-Clause "New" or "Revised" License

52 stars 30 forks source link

pins2lts-sym.c is now only compiled once, meaning that compile flags dont have any effect. #112

Closed Meijuh closed 7 years ago

Meijuh commented 7 years ago

Such as flags defined in pins-impl.h.

alaarman commented 7 years ago

111 is affected as well.

alaarman commented 7 years ago

@trolando has a patch on his branch (a partial revert of the compile-once commit).

Meijuh commented 7 years ago

Okay, I'll close this issue when Tom's commits are merged.

trolando commented 7 years ago

I'll do a pull request of some of the commits

On Tue, May 30, 2017 at 1:32 PM, Jeroen Meijer notifications@github.com wrote:

Okay, I'll close this issue when Tom's commits are merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/utwente-fmt/ltsmin/issues/112#issuecomment-304851002, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlcXc8bE53oKRDutk-cPjg3TTue_dDwks5r-_5fgaJpZM4NqKMJ .

alaarman commented 7 years ago

114 also fixes it and leaves the one-time compilation intact

Meijuh commented 7 years ago

I think the best solution for now is to do a pull request of @trolando's next branch. And postpone the refactoring of the symtool to v3.1.0.

Meijuh commented 7 years ago

I ended up cherry-picking a necessary commit from @trolando next branch: 93b5abb5f1b2350e87fcecce48a27021d9181eca. This issue is solved now.