utxostack / ckb-bitcoin-spv-service

Synchronize headers to Bitcoin SPV clients running on the CKB chain.
MIT License
1 stars 4 forks source link

chore: update a terrible function naming #29

Closed yangby-cryptape closed 5 months ago

yangby-cryptape commented 5 months ago

Description

Yep!

If expect storage to generate a headers proof for on-chain headers, then storage has to contain more headers than on-chain.


It's a terrible function name. That's why you were confused.

I guess when I wrote this function, I think about the best SPV client should be included in storage, so I just wrote such a terrible name.

A best name should be find_best_spv_client_under_height.

Original post by comment in PR-25