search

uudashr / jsmpp

Java SMPP (Short Message Peer-to-peer Protocol) API
Apache License 2.0
121 stars 118 forks source link

Option to Send deliverSmResp manually #27

Open fjordansilva opened 10 years ago

fjordansilva commented 10 years ago

Modifying the interface MessageReceiverListener, adding a boolean return value to onAcceptDeliverSm the user can choose if JSMPP sends the deliver_sm_resp message once the method has finished or (using FALSE value) doesn't allow to JSMPP to send the message.

This modification is necessary for working with async systems (Vert.x for example). With async system you can not send a response to SMSC because most of the times the original message ( deliver_sm ) has not been processed.

This PR also fix a NullPointer exception that happens when JSMPP tryes to bind to a SMSC that doesn't replay any optional parameter

ADTC commented 10 years ago

Looks like you made too many trivial changes that it has become hard to find your changes that matter. Try to avoid automatic formatting or changes done by IDE.

dpocock commented 9 years ago

I've copied your pull request into the branch here: https://github.com/opentelecoms-org/jsmpp/commits/fjordansilva-master to see it build in travis