search

uugear / Witty-Pi-4

Software and Firmware for Witty Pi 4
MIT License
23 stars 16 forks source link

Q: Shellcheck Contributions? #14

Closed tomjn closed 5 months ago

tomjn commented 1 year ago

If I ran shellcheck on the script and sent a PR with fixes would it be welcomed? I know shellcheck has a lot of opinions, some with good reason, e.g. this:

  local startup_time=$(get_startup_time)
  if [ "$startup_time" == "0 0:0:0" ]; then
    echo '  Auto startup time is not set yet.'
  else
    echo "  Auto startup time is currently set to \"$startup_time\""
  fi

Would probably turn into something like this:

    local startup_time
    startup_time=$(get_startup_time)
    if [ "${startup_time}" == "0 0:0:0" ]; then
        echo '  Auto startup time is not set yet.'
    else
        echo "  Auto startup time is currently set to \"${startup_time}\""
    fi
tomjn commented 5 months ago

@uugear I see you closed this as "not planned" but this wasn't a feature request, I was offering my own time and wanted to know if spending my own time to improve the repo would be welcomed. Was this an automated closure?