uuid6 / uuid6-ietf-draft

Next Generation UUID Formats
https://datatracker.ietf.org/doc/draft-peabody-dispatch-new-uuid-format/
187 stars 11 forks source link

Typo in UUIDv7 example value #123

Closed kyzer-davis closed 2 years ago

kyzer-davis commented 2 years ago

Change Proposal Template

Source (Select one.)

Change Reason (Select all that apply.)

Draft Number, Full Section, Name

The timestamp is Tuesday, February 22, 2022 2:22:22.00 PM GMT-05:00

Current Text:

UUIDs MAY be universally unique.

Proposed Text:

The timestamp is Tuesday, February 22, 2022 14:22:22.00 PM GMT-05:00

Other Supporting information below:

From: Ben Ramsey ben@benramsey.com

As I was working on some tests for an implementation, I came across what I think might be a typo in draft-peabody-dispatch-new-uuid-format-04, Appendix B.2:

    The timestamp is Tuesday, February 22, 2022 2:22:22.00 PM GMT-05:00
    represented as 0x17F22E279B0 or 1645557742000

The hex value mentioned does convert properly to 1645557742000. However, when converting 1645557742000 to seconds (1645557742), the timestamp evaluates to:

    Tuesday, February 22, 2022 14:22:22.00 PM GMT-05:00

See, for example, https://duckduckgo.com/?q=1645557742+unix+timestamp&t=osx&ia=answer&iax=answer

I think the time in the text should change from “2:22:22.00” to “14:22:22.00”.

Cheers,
Ben
ramsey commented 2 years ago

You may ignore and close this issue. There is no typo.

I missed the "PM" in the time string and thought the string meant 2 AM. Since "PM" is in the string, it is correct.

I feel quite silly now. Sorry for the churn. 😄

❯ TZ='America/New_York' date --date='@1645557742' '+%A, %B %-d, %Y %-I:%M:%S %p GMT%:z'
Tuesday, February 22, 2022 2:22:22 PM GMT-05:00