Closed broofa closed 4 months ago
@LinusU @pmccarren I would particularly appreciate a review of the TS types I've added, particularly with regard to API surface where I've used overload signatures to capture the different method incantations.
@ctavan et al: Thoughts on release process? I know we just pushed v10, so pushing a v11 this soon after feels a bit... sudden? We could do a prerelease ("11.0.0-beta") and dist tag as npm dist-tag add 11.0.0-beta beta
, I suppose.
@joshkel As the most recent contributor to @types/uuid, I'd certainly appreciate any feedback you have on this.
Final call. Merging this by week's end unless someone objects.
@ctavan @LinusU @pmccarren @joshkel
Switching the codebase to Typescript.
Uint8Array
for binary uuids throughout (BREAKING CHANGE)jest
tonode:test
tsc
for generating buidlsOther notes:
Uint8Array
for binary UUIDsexamples/node-jest
test passes, but I don't see it being run as part of CI ornpm test
anywhere. I'm tempted to remove it. 🤔eslint@latest
, and switched config to ESM.@wdio/*@latest
prettier
config to ESMtasks.json
starts thebuild:watch
andtest:watch
scripts automatically when you open the projectextensions.json
identifies the plugins that devs should use to apply oureslint
andprettier
settings while editing codepackage.json#scripts
alphabeticallybuild:watch
andtest:watch
scripts, which I'm using in vscodedist/esm
directory (unless they're explicitely testing other dist/* builds.build.sh
now builds ESM and CJS versions of code usingtsc
rather than babel.dist/*.js
files can now be found indist/esm
, alongside the other builds (esm-browser
,cjs
, andcjs-browser
)Uint8Array
for binary (byte) UUID data structures throughout. The one exception is the return type formd5
andsha1
on node, which is still Buffer (but that's a subclass of Uint8Array these days anyways so... 🤷)