search

uujgii / web-to-print-scripts

Automatically exported from code.google.com/p/web-to-print-scripts
0 stars 0 forks source link

Edit button for image editing #43

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Bind to EDIT button for images in My images.
We should have only one editor available. At the moment clicking on the image 
pops a fancybox and Edit opens native editor.

Should be fancybox where the script is active.

Original issue reported on code.google.com by zetapri...@gmail.com on 27 Jun 2010 at 10:32

GoogleCodeExporter commented 9 years ago

Original comment by trilobit.alex@gmail.com on 27 Jun 2010 at 10:42

GoogleCodeExporter commented 9 years ago 
SVN release
http://code.google.com/p/web-to-print-scripts/source/detail?r=123

How it work
Now Edit pops a fancybox, native editor is disabled.

Original comment by trilobit.alex@gmail.com on 28 Jun 2010 at 8:15

GoogleCodeExporter commented 9 years ago 
See comments for the release.
http://code.google.com/p/web-to-print-scripts/source/detail?r=123

Original comment by zetapri...@gmail.com on 28 Jun 2010 at 8:25

GoogleCodeExporter commented 9 years ago 
SVN release
http://code.google.com/p/web-to-print-scripts/source/detail?r=124

How it work
Now Edit pops a fancybox, native editor is disabled.

Original comment by trilobit.alex@gmail.com on 28 Jun 2010 at 9:03

GoogleCodeExporter commented 9 years ago 
Do not allow image editing on images that cannot be edited.
It is evident by prefix 'm' on the native image editing menu.
Those that can be edited have 'mul'.

Images with 'm' can only be deleted.

So, we show the fancybox, but disable all the editing in there except for 
delete.

Original comment by zetapri...@gmail.com on 28 Jun 2010 at 9:41

GoogleCodeExporter commented 9 years ago 
http://code.google.com/p/web-to-print-scripts/source/detail?r=124
See review comments.

<a> that envelops the image on preview page has @id structured as this
img-s-1-2 or img-l-3-17
where
s = the image is a stock image and should show in a fancy box with no editing 
options
1,3 = image field idx
2,17 = image idx in the scroll
l = user image, can be edited

A similar logic applies to images on My Images pages, but the structure is 
different.

Original comment by zetapri...@gmail.com on 28 Jun 2010 at 11:48

GoogleCodeExporter commented 9 years ago 
I think, will be better if images in the scroll will have desc sorting. New 
image will have incremental index and no need to go all images to change 
indexes. It will be faster.

Original comment by trilobit.alex@gmail.com on 30 Jun 2010 at 8:23

GoogleCodeExporter commented 9 years ago 
Don't change the numbering.
Make them appear without a number.
The should be image name anyway. 
We'll fix it up later.

Original comment by zetapri...@gmail.com on 30 Jun 2010 at 9:53

GoogleCodeExporter commented 9 years ago 
SVN release
http://code.google.com/p/web-to-print-scripts/source/detail?r=125

How it works
Now Edit pops a fancybox, native editor is disabled.
But, after upload new image, server returns different block with preview. It 
has not have second string (<tr>) with link for a folder

Original comment by trilobit.alex@gmail.com on 30 Jun 2010 at 11:56

GoogleCodeExporter commented 9 years ago 
Makes no sense.

Original comment by zetapri...@gmail.com on 30 Jun 2010 at 11:52

GoogleCodeExporter commented 9 years ago 
Last SVN release
http://code.google.com/p/web-to-print-scripts/source/detail?r=126

Last changes
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn126&old=125&r=
126&format=side&path=%2Fbranches%2Fbulk_upload%2FmultiFileUpload.js
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn126&old=125&r=
126&format=side&path=%2Fbranches%2Ffile_upload%2FfileUpload.js
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn126&old=125&r=
126&format=side&path=%2Fbranches%2Fimage_editor%2FimageEditor.js

Changes at this issue
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn126&old=124&r=
126&format=side&path=%2Fbranches%2Fbulk_upload%2FmultiFileUpload.js
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn126&old=122&r=
126&format=side&path=%2Fbranches%2Ffile_upload%2FfileUpload.js
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn126&old=124&r=
126&format=side&path=%2Fbranches%2Fimage_editor%2FimageEditor.js

Original comment by trilobit.alex@gmail.com on 1 Jul 2010 at 12:29

GoogleCodeExporter commented 9 years ago 
The code changes look alright. Let's see if it works.

Original comment by zetapri...@gmail.com on 1 Jul 2010 at 12:34

GoogleCodeExporter commented 9 years ago 
Tested on realestate.zetaprints.com in FF, Chrome, IE8 and IE6.

1. Since both image and button clicks open the image editor now, we need to 
change the hover name of the image thumb from "Click to enlarge" to "Click to 
edit" (hover_title.png)

2. Some problems occur after an uploaded image is renamed. The old script comes 
to play if you do so. Instructions to replicate:
- Navigate to "My Images" page in IE (this is not a IE err but G-skin only 
shows the renaming field in IE, will post a separate G-skin issue on this)
- Click on the input field above the image thumb (rename_box.png), input some 
text and hit Enter to save.
- Click on the image thumb or Edit button, 
- You should see the old behavior come to play, click on thumb opens the image 
in a new window, button opens the drop down menu (edit_dropdown.png).

3. IE6 only err
Replication is identical as explained in 2.
After image renaming the "Edit" button re-appears again - script becomes active.

Original comment by agur...@gmail.com on 1 Jul 2010 at 6:00

Attachments:

GoogleCodeExporter commented 9 years ago 
4. Images that have editing forbidden show a err (stock_img_err.png).

Instruction to replicate:
- Use this template:
http://realestate.zetaprints.com/?page=template;TemplateID=D13AAB30-2E26-43A3-84
CE-12A7424CE95C
- There's a stock images selection on the bottom. Stock images cannot be 
edited. When I click on the thumb, the new script comes to play and tries to 
open the new image editor. Since this is not allowed, the browser pops up an 
err.

Original comment by agur...@gmail.com on 1 Jul 2010 at 6:06

Attachments:

GoogleCodeExporter commented 9 years ago 
Last SVN release
http://code.google.com/p/web-to-print-scripts/source/detail?r=127

Last changes
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn127&r=127&form
at=side&path=/branches/bulk_upload/multiFileUpload.js
http://code.google.com/p/web-to-print-scripts/source/diff?format=side&path=/bran
ches/file_upload/fileUpload.js&r=127&spec=svn127
http://code.google.com/p/web-to-print-scripts/source/diff?format=side&path=/bran
ches/image_editor/imageEditor.js&r=127&spec=svn127
http://code.google.com/p/web-to-print-scripts/source/diff?format=side&path=/bran
ches/image_editor/zp-image-edit.js&r=127&spec=svn127

Changes at this issue
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn127&old=124&r=
127&format=side&path=%2Fbranches%2Fbulk_upload%2FmultiFileUpload.js
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn127&old=122&r=
127&format=side&path=%2Fbranches%2Ffile_upload%2FfileUpload.js
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn127&old=124&r=
127&format=side&path=%2Fbranches%2Fimage_editor%2FimageEditor.js
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn127&old=99&r=1
27&format=side&path=%2Fbranches%2Fimage_editor%2Fzp-image-edit.js

Original comment by trilobit.alex@gmail.com on 3 Jul 2010 at 9:48

GoogleCodeExporter commented 9 years ago 
Last SVN release
http://code.google.com/p/web-to-print-scripts/source/detail?r=129

Last changes
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn129&r=129&form
at=side&path=/branches/bulk_upload/multiFileUpload.js
http://code.google.com/p/web-to-print-scripts/source/diff?format=side&path=/bran
ches/file_upload/fileUpload.js&r=129&spec=svn129
http://code.google.com/p/web-to-print-scripts/source/diff?format=side&path=/bran
ches/image_editor/imageEditor.js&r=129&spec=svn129

Changes at this issue
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn129&old=124&r=
129&format=side&path=%2Fbranches%2Fbulk_upload%2FmultiFileUpload.js
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn129&old=122&r=
129&format=side&path=%2Fbranches%2Ffile_upload%2FfileUpload.js
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn129&old=124&r=
129&format=side&path=%2Fbranches%2Fimage_editor%2FimageEditor.js
http://code.google.com/p/web-to-print-scripts/source/diff?spec=svn127&old=99&r=1
27&format=side&path=%2Fbranches%2Fimage_editor%2Fzp-image-edit.js

Original comment by trilobit.alex@gmail.com on 5 Jul 2010 at 4:35

GoogleCodeExporter commented 9 years ago 
EPS images (any browser)
These images do not allow editing (rotation, cropping...). When I click on the 
thumb of a EPS image in the grid on "My images" page, it opens the fancybox and 
the editingo ptions are available. Editing pops up an err (eps_fancy_box.png)
Replication instructions:
- Navigate to "My images" page on realestate.zetaprints.com
- Upload a EPS image, or use mine if you're logged in as printer (attached a 
EPS image just in case you need one.)
- Click on the thumbnail and then click on one of the editing options (ex. 
rotate left)
- You should see an err come up.

Original comment by agur...@gmail.com on 5 Jul 2010 at 9:38

Attachments:

GoogleCodeExporter commented 9 years ago 
Looks like a ZP error.
We need to add a mime type attribute somewhere to tell which ones are editable, 
which ones are not.

Original comment by zetapri...@gmail.com on 6 Jul 2010 at 5:49

GoogleCodeExporter commented 9 years ago 
Fixed, please, test it.

Original comment by trilobit.alex@gmail.com on 7 Jul 2010 at 5:57

GoogleCodeExporter commented 9 years ago

Original comment by agur...@gmail.com on 7 Jul 2010 at 3:26

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 17 Jul 2010 at 2:23