uuksu / RPGMakerDecrypter

Tool for extracting RPG Maker XP, VX and VX Ace encrypted archives.
MIT License
197 stars 42 forks source link

Add keyword argument to control overwriting behavior of the decrypter #19

Closed AhmedAhmedEG closed 4 months ago

AhmedAhmedEG commented 6 months ago

The overwriting behavior is not exposed from the keyword arguments, I added a --overwrite argument to exactly do that.

uuksu commented 4 months ago

Hey and sorry for taking so long time to react. Your change seems good to me, but I would like to see the flag also implemented in the GUI so that both programs are equal. It could be implemented as a optional checkbox somewhere. If you can do this, I'll merge you PR.

AhmedAhmedEG commented 4 months ago

Ok, I will try so.

AhmedAhmedEG commented 4 months ago

Ok, I did it, I modified the Gui project and added a checkbox for the overwriting, and tested it and it works, also the IDE automatically did grammar corrects to the texts used in the GUI that was there already, so this makes it even better.

uuksu commented 4 months ago

That's perfect, thank you! I'll merge your PR now.