uureel / batocera.pro

This repo is scheduled for phase out // Unofficial apps for Batocera, installation info below
http://batocera.pro
GNU General Public License v3.0
174 stars 37 forks source link

extract-xiso missing .exe #7

Closed udance4ever closed 1 year ago

udance4ever commented 1 year ago

hi! I’m new to these scripts - I was trying to figure out why this app doesn’t boot in Applications and it looks like the .exe (referenced in the Launcher created by extract-xiso.sh) is missing:

https://github.com/uureel/batocera.pro/blob/b2c7ee2f6dfdae7bfcb361220b6b9b415d6bb6b6/extract-xiso/extract-xiso.sh#L23

udance4ever commented 1 year ago

I’ve run into this issue before with the build of unzip in busybox - it has trouble with certain kinds of zips (that work fine in Linux or macOS) - this is what happens in batocera.linux:

root@BATOCERA /userdata/system/pro/extract-xiso/extra/downloads]# unzip --qq extract-xiso.zip
[extract-xiso.zip]
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of extract-xiso.zip or
        extract-xiso.zip.zip, and cannot find extract-xiso.zip.ZIP, period.
uureel commented 1 year ago

thx, should be now fixed @ https://github.com/uureel/batocera.pro/commit/644daea756def735a385e255330d3cd56d86257b

udance4ever commented 1 year ago

tested - works great now!