search

uureel / batocera.pro

This repo is scheduled for phase out // Unofficial apps for Batocera, installation info below
http://batocera.pro
GNU General Public License v3.0
174 stars 37 forks source link

peazip.sh ${APPNAME^^} returns null which results in incorrect name for downloaded .AppImage #8

Closed udance4ever closed 1 year ago

udance4ever commented 1 year ago

the following code causes the .Applmage to be downloaded as .AppImage instead of peazip.AppImage:

https://github.com/uureel/batocera.pro/blob/b2c7ee2f6dfdae7bfcb361220b6b9b415d6bb6b6/peazip/peazip.sh#L20

I’m not familiar with this syntax - what is ${APPNAME^^} and ${APPHOME^^} intended to do? remove trailing whitespace?

is it possible it works in your development shell and not the batocera.linux shell?

I’m also in macOS and the expression isn’t working in bash on this end either.

udance4ever commented 1 year ago

figured it out - created a pull request: https://github.com/uureel/batocera.pro/pull/9

ps. also figured out that ${VAR^^} is a neat way to convert to uppercase and works in bash over in batocera.linux but not in bash over in macOS 🙄