search

uutils / coreutils

Cross-platform Rust rewrite of the GNU coreutils
https://uutils.github.io/
MIT License
17.63k stars 1.27k forks source link

make utilities work with non-UTF-8 inputs #554

Open kwantam opened 9 years ago

kwantam commented 9 years ago

Since the String types in Rust are by nature UTF-8, many of these utilities make the implicit assumption that all inputs will be UTF-8 encoded. It might be useful to expand the capabilities to include non-UTF-8 string handling as well. #553 does this for expand and unexpand, but many other utilities don't fare so well (e.g., fmt).

remram44 commented 9 years ago

The problem is that getopts returns Strings, so unless it gets patched or this project switches to something else, it's never going to work.

See also #203, rust-lang/getopts#28

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

remram44 commented 3 years ago

@Arcterus the bot seems misconfigured, it's marking accepted issues as stale.

sylvestre commented 3 years ago

I configured the bot this way. It didn't see any chance for 3 years, this is why it is marked as staled (which is clearly the case here)

remram44 commented 3 years ago

For that definition, it is indeed stale, however it is still an open issue. Marking actual issues as "closed" hurts the community. Why do this?

sylvestre commented 3 years ago

Because keeping bugs open for years without any activity isn't providing any benefit for anyone and reopening bugs is cheap.

remram44 commented 3 years ago

Reopening bugs is cheap for you, in that it annoys somebody else. I'm sorry you want to treat your community this way, but you can do what you want.

Luckily the real coreutils treat product quality better. If you're happy being a toy reimplementation rather than providing a usefuly rewrite, that is a valid choice. You should probably update your README though.

Arcterus commented 3 years ago

@remram44 I think you're going a bit too far there.

@sylvestre I'm not sure why you would want to close an issue for a bug just because there hasn't been activity. It's not like the bug has disappeared. If anything, I think this just makes it harder to keep track of things. It's fine to mark stuff as stale, but only stale PRs should be closed IMO.

Also, I don't actually think this is stale. All the PRs switching from getopts to clap help with this issue.

sylvestre commented 3 years ago

Also, I don't actually think this is stale. All the PRs switching from getopts to clap help with this issue.

Yeah, you probably saw that I opened plenty of good first bugs for this. ;) It is probably more concrete than 6 years old inactive bugs.

Arcterus commented 3 years ago

Well, this bug encompasses more than just switching to clap (although admittedly that is a significant portion of it). So, I guess we can either split this into a new bug for every utility or make this more of tracking issue (the latter is my preference).

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.