uutils / coreutils

Cross-platform Rust rewrite of the GNU coreutils
https://uutils.github.io/
MIT License
17.23k stars 1.24k forks source link

ls: gnu `color-norm` test fix #6481

Closed matrixhead closed 1 week ago

matrixhead commented 2 weeks ago

This pr tries to fix gnu test case color-norm for ls util these behaviors that are changed

github-actions[bot] commented 2 weeks ago

GNU testsuite comparison:

GNU test failed: tests/ls/multihardlink. tests/ls/multihardlink is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/rm2. tests/rm/rm2 is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)
sylvestre commented 2 weeks ago

Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing! Congrats! The gnu test tests/ls/color-norm is no longer failing! Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!

Sweet!

github-actions[bot] commented 2 weeks ago

GNU testsuite comparison:

Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
github-actions[bot] commented 1 week ago

GNU testsuite comparison:

GNU test failed: tests/sort/sort-debug-keys. tests/sort/sort-debug-keys is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
Congrats! The gnu test tests/timeout/timeout is no longer failing!
github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
sylvestre commented 1 week ago

excellent, please let me know when it is ready for review :)

github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
sylvestre commented 1 week ago

I guess you saw: error: the lock file /home/runner/work/coreutils/coreutils/Cargo.lock needs to be updated but --locked was passed to prevent this

matrixhead commented 1 week ago

i need to add newly generated cargo.lock to fix this right? but other tests failing where failing when i do this

sylvestre commented 1 week ago

See

error: package `clap_mangen v0.2.21` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0
Either upgrade to rustc 1.74 or newer, or use
cargo update -p clap_mangen@0.2.21 --precise ver
where `ver` is the latest version of `clap_mangen` supporting rustc 1.70.0
github-actions[bot] commented 1 week ago

GNU testsuite comparison:

GNU test failed: tests/sort/sort-debug-keys. tests/sort/sort-debug-keys is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Congrats! The gnu test tests/ls/color-dtype-dir is no longer failing!
Congrats! The gnu test tests/ls/color-norm is no longer failing!
Congrats! The gnu test tests/ls/dired is no longer failing!
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
sylvestre commented 1 week ago

Three tests passing, this is amazing. well done!

matrixhead commented 1 week ago

thank you 😃 but 'stat-free-symlink' is still failing for me locally 😅