search

uutils / coreutils

Cross-platform Rust rewrite of the GNU coreutils
https://uutils.github.io/
MIT License
17.23k stars 1.24k forks source link

`touch`: change message when directory #6506

Closed Its-Just-Nans closed 2 days ago

Its-Just-Nans commented 5 days ago

Should fix https://github.com/uutils/coreutils/issues/2639

sylvestre commented 5 days ago

Please add a test to make sure we don't regress

Its-Just-Nans commented 5 days ago

Yes you're right

Now the code is also cleaner I think

sylvestre commented 5 days ago

the initial commit message isn't ideal btw " change message when directory " :)

Its-Just-Nans commented 5 days ago

Can you just squash all commits ? (when merging)

Or I can squash them if needed :)

sylvestre commented 5 days ago

sure but it is still appreciated to have valid commit message. esp as github uses the first as input :)

Its-Just-Nans commented 5 days ago

my bad

Is-it correct now ?

github-actions[bot] commented 2 days ago

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)