search

uutils / findutils

Rust implementation of findutils
MIT License
300 stars 37 forks source link

find: Implement `-newerXY` #342

Closed hanbings closed 6 months ago

hanbings commented 6 months ago

link: https://github.com/uutils/findutils/issues/307

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 78.50467% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 59.12%. Comparing base (450c4ae) to head (aea6b66).

:exclamation: Current head aea6b66 differs from pull request most recent head dcbf986. Consider uploading reports for the commit dcbf986 to get more accurate results

Files Patch % Lines
src/find/matchers/mod.rs 71.42% 1 Missing and 13 partials :warning:
src/find/matchers/time.rs 84.48% 1 Missing and 8 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #342 +/- ## ========================================== + Coverage 58.59% 59.12% +0.53% ========================================== Files 30 30 Lines 3712 3736 +24 Branches 840 847 +7 ========================================== + Hits 2175 2209 +34 + Misses 1223 1218 -5 + Partials 314 309 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sylvestre commented 6 months ago

Could you please add unit and integration tests? Thanks

hanbings commented 6 months ago

Okay, I will add the test code as soon as possible.

sylvestre commented 6 months ago

Thanks

cakebaker commented 6 months ago

@hanbings apart from the tests, is the code ready for review?

hanbings commented 6 months ago

@hanbings apart from the tests, is the code ready for review?

I'm sorry I just saw the message. I've added some test code, but there seems to be something wrong with the Github Actions being tested, and I'm not quite sure the test code meets the coverage requirements. In addition, there is another piece of file system compatibility code that is not yet ready.

But yeah, ready to review. Thank you.