Closed hanbings closed 2 months ago
Attention: Patch coverage is 88.88889%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 59.41%. Comparing base (
d8e2ce2
) to head (0febdac
).
Files | Patch % | Lines |
---|---|---|
src/find/matchers/mod.rs | 66.66% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
could you please add a test here: https://github.com/uutils/findutils/blob/main/tests/find_cmd_tests.rs thanks
could you please add a test here: https://github.com/uutils/findutils/blob/main/tests/find_cmd_tests.rs thanks
OK, it's included in the latest commit.
Thanks!
fix: https://github.com/uutils/findutils/issues/29
This commit modifies a test function
build_top_level_matcher_too_many_brackets
outside of my code, which tests thatfind -true \( \) \)
will return atoo many ')'
error.But in GNU find, this instruction will first cause an
empty parentheses are not allowed
error, so it is changed tofind . -type f \( -name "*.txt" \) \)
to maintain compatibility.