uutils / findutils

Rust implementation of findutils
MIT License
280 stars 36 forks source link

clippy: Fix clippy warning. #357

Closed hanbings closed 2 months ago

hanbings commented 2 months ago

I'm sorry that I wrote some redundant code at https://github.com/uutils/findutils/pull/353 and https://github.com/uutils/findutils/pull/342 which caused cargo clippy --all-targets --all-features to generate multiple warnings.

Fix them in this PR.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.58%. Comparing base (6a83795) to head (acd5c4b). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #357 +/- ## ========================================== - Coverage 59.35% 58.58% -0.78% ========================================== Files 30 30 Lines 3831 3815 -16 Branches 872 859 -13 ========================================== - Hits 2274 2235 -39 - Misses 1218 1257 +39 + Partials 339 323 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cakebaker commented 2 months ago

No need to be sorry :) I added --all-targets to the CI in https://github.com/uutils/findutils/pull/359, so in the future the CI should catch such issues.

Thanks for fixing the issues!