search

uutils / findutils

Rust implementation of findutils
MIT License
280 stars 35 forks source link

find: Implement `-samefile` #389

Closed hanbings closed 1 week ago

hanbings commented 1 month ago

implement: https://github.com/uutils/findutils/issues/373

BFS test +1 PASS and GNU test PASS +8 / FAIL -20 in commit bc8ae9859ef41b21a67ab0b72143751240659e3a

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.43%. Comparing base (42075f5) to head (a523add). Report is 4 commits behind head on main.

Files Patch % Lines
src/find/matchers/mod.rs 60.00% 1 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #389 +/- ## ========================================== + Coverage 64.96% 65.43% +0.47% ========================================== Files 32 33 +1 Lines 3810 3888 +78 Branches 874 892 +18 ========================================== + Hits 2475 2544 +69 Misses 993 993 - Partials 342 351 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sylvestre commented 3 weeks ago

And I waiting for https://github.com/uutils/findutils/pull/400 to review this first :)

github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 706 / PASS: 441 / FAIL: 262 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +8 / FAIL -20 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105
sylvestre commented 1 week ago

@hanbings is that expected ? :) PASS +8 / FAIL -20 / ERROR +0 / SKIP +0

hanbings commented 1 week ago

If we mean the GNU/BFS tests for the code in this PR itself, yes.

github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 706 / PASS: 441 / FAIL: 262 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +8 / FAIL -20 / ERROR +0 / SKIP +0
github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 706 / PASS: 441 / FAIL: 262 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +8 / FAIL -20 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 184 / SKIP: 1 / FAIL: 103
github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 184 / SKIP: 1 / FAIL: 103
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-copy.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-link.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 706 / PASS: 441 / FAIL: 262 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +8 / FAIL -20 / ERROR +0 / SKIP +0