Closed cakebaker closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 60.51%. Comparing base (
5b19ea2
) to head (cd0e119
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
GNU testsuite comparison:
Run GNU findutils tests: GNU tests summary = TOTAL: 718 / PASS: 433 / FAIL: 282 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105
@hanbings maybe we should display it only when here are changes. it will be too noisy otherwise
@hanbings maybe we should display it only when here are changes. it will be too noisy otherwise
OK, I'll open a new PR to work on it.
This PR is a refactoring that makes the implementations of
InodeMatcher
andLinksMatcher
unix-only. And moves the error handling for other platforms to where we handle-inum
and-links
.The refactoring is done to get rid of two "field x is never read" warnings on Windows (see, for example, https://github.com/uutils/findutils/actions/runs/9271426702/job/25506758917#step:6:185)