Closed hanbings closed 5 months ago
Attention: Patch coverage is 75.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 58.88%. Comparing base (
3badb05
) to head (bd759d5
).
Files | Patch % | Lines |
---|---|---|
src/find/matchers/time.rs | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
please add tests to make sure we don't regress, thanks
@sylvestre: hm, what tests are you looking for? As far as I see it, this PR is about fixing the broken tests on Windows, so the tests are already there.
oups, sorry
fs::remove_file
in Windows platform tests may return anOk()
even if the file is not deleted immediately, which will cause an error in the code in the test that assumes the file is deleted./
separators were accidentally escaped as\\
. Now it has been changed to usecontains
to determine whether the output contains a specific path and ignore the path separator problem.