Closed hanbings closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 65.31%. Comparing base (
f2202dc
) to head (ac4ef9d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
GNU testsuite comparison:
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105
Run GNU findutils tests: GNU tests summary = TOTAL: 718 / PASS: 433 / FAIL: 282 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0
GNU testsuite comparison:
Run GNU findutils tests: GNU tests summary = TOTAL: 718 / PASS: 433 / FAIL: 282 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105
GNU testsuite comparison:
Run GNU findutils tests: GNU tests summary = TOTAL: 718 / PASS: 433 / FAIL: 282 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests No changes
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105
i guess it isn't ready yet, right ? :)
Yeah, I haven't tested this code on my fork yet. I originally wanted to mark this PR as Draft, but Github doesn't seem to show me that button. I'll mention you here when I'm done, thanks! :)
@sylvestre done. This is a sample generated during testing: https://github.com/hanbings/findutils/pull/19#issuecomment-2192890112 Is there anything else we need to add?
GNU testsuite comparison:
Run GNU findutils tests: GNU tests summary = TOTAL: 706 / PASS: 441 / FAIL: 262 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests No changes
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 186 / SKIP: 1 / FAIL: 101
sorry, looks like i wasn't cleary. What I would like is to have nothing to display when BFS tests or Gnu tests = No changes
we should only display something when we noticed changes in bfs or gnu tests
sorry, looks like i wasn't cleary. What I would like is to have nothing to display when BFS tests or Gnu tests = No changes
we should only display something when we noticed changes in bfs or gnu tests
No, actually it does not send comments when it contains No changes
. But Github Actions will only execute the workflows file of the default branch, and the logic of whether to send comments is in the comment.yml
file, so we need to merge this PR first to see the final effect.
ok, let's see :)
Tested in fork, this change may still only take effect after being merged.