uutils / findutils

Rust implementation of findutils
MIT License
280 stars 35 forks source link

Comments are only sent when GNU/BFS test compatibility changes. #407

Closed hanbings closed 1 week ago

hanbings commented 1 week ago

Tested in fork, this change may still only take effect after being merged.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.31%. Comparing base (f2202dc) to head (ac4ef9d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #407 +/- ## ======================================= Coverage 65.31% 65.31% ======================================= Files 34 34 Lines 3941 3941 Branches 903 903 ======================================= Hits 2574 2574 Misses 1001 1001 Partials 366 366 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105
Run GNU findutils tests: GNU tests summary = TOTAL: 718 / PASS: 433 / FAIL: 282 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 718 / PASS: 433 / FAIL: 282 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105
github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 718 / PASS: 433 / FAIL: 282 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests No changes
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105
sylvestre commented 1 week ago

i guess it isn't ready yet, right ? :)

hanbings commented 1 week ago

Yeah, I haven't tested this code on my fork yet. I originally wanted to mark this PR as Draft, but Github doesn't seem to show me that button. I'll mention you here when I'm done, thanks! :)

hanbings commented 1 week ago

@sylvestre done. This is a sample generated during testing: https://github.com/hanbings/findutils/pull/19#issuecomment-2192890112 Is there anything else we need to add?

github-actions[bot] commented 1 week ago

GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 706 / PASS: 441 / FAIL: 262 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests No changes
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 186 / SKIP: 1 / FAIL: 101
sylvestre commented 1 week ago

sorry, looks like i wasn't cleary. What I would like is to have nothing to display when BFS tests or Gnu tests = No changes

we should only display something when we noticed changes in bfs or gnu tests

hanbings commented 1 week ago

sorry, looks like i wasn't cleary. What I would like is to have nothing to display when BFS tests or Gnu tests = No changes

we should only display something when we noticed changes in bfs or gnu tests

No, actually it does not send comments when it contains No changes. But Github Actions will only execute the workflows file of the default branch, and the logic of whether to send comments is in the comment.yml file, so we need to merge this PR first to see the final effect.

sylvestre commented 1 week ago

ok, let's see :)