search

uutils / findutils

Rust implementation of findutils
MIT License
314 stars 38 forks source link

Wrap walkdir::DirEntry in a new type #436

Closed tavianator closed 3 months ago

tavianator commented 3 months ago

Includes #420.

Closes #12. Closes #308. Closes #379. Closes #412. Closes #440. Implements the Metadata caching part of #430.

github-actions[bot] commented 3 months ago

Commit 65019fb186325304d3d6cfbf0852bc58c3415c84 has GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +34 / SKIP +0 / FAIL -34
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 227 / SKIP: 1 / FAIL: 60
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 663 / PASS: 473 / FAIL: 187 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +28 / FAIL -67 / ERROR +0 / SKIP +0
github-actions[bot] commented 3 months ago

Commit a7a5e4d5f5a175e5a5c4a5d3419bbff4b0c1f04e has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 663 / PASS: 473 / FAIL: 187 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +28 / FAIL -67 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +34 / SKIP +0 / FAIL -34
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 227 / SKIP: 1 / FAIL: 60
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 78.65169% with 76 lines in your changes missing coverage. Please review.

Project coverage is 66.31%. Comparing base (465856c) to head (7b97d74). Report is 1 commits behind head on main.

Files Patch % Lines
src/find/matchers/entry.rs 80.86% 23 Missing and 8 partials :warning:
src/find/matchers/mod.rs 58.33% 10 Missing and 10 partials :warning:
src/find/matchers/printf.rs 64.70% 3 Missing and 3 partials :warning:
src/find/matchers/samefile.rs 61.53% 2 Missing and 3 partials :warning:
src/find/matchers/type_matcher.rs 87.50% 1 Missing and 3 partials :warning:
src/find/matchers/delete.rs 57.14% 1 Missing and 2 partials :warning:
src/find/matchers/group.rs 50.00% 0 Missing and 2 partials :warning:
src/find/matchers/user.rs 50.00% 0 Missing and 2 partials :warning:
src/find/mod.rs 90.90% 1 Missing and 1 partial :warning:
src/find/matchers/time.rs 91.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #436 +/- ## ========================================== + Coverage 66.08% 66.31% +0.22% ========================================== Files 34 35 +1 Lines 4043 4278 +235 Branches 917 958 +41 ========================================== + Hits 2672 2837 +165 - Misses 1000 1041 +41 - Partials 371 400 +29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Commit 72bb813648404c223f7be2dc8b019bb7f04f54e4 has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 663 / PASS: 473 / FAIL: 187 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +28 / FAIL -67 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +34 / SKIP +0 / FAIL -34
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 227 / SKIP: 1 / FAIL: 60
sylvestre commented 3 months ago

Impressive:

Run GNU findutils tests: Changes from main: PASS +28 / FAIL -67 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +34 / SKIP +0 / FAIL -34
github-actions[bot] commented 3 months ago

Commit 276ebda930bb3e2c82dcd3c78dc4761f02c5a7e0 has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 663 / PASS: 473 / FAIL: 187 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +28 / FAIL -67 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +34 / SKIP +0 / FAIL -34
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 227 / SKIP: 1 / FAIL: 60
github-actions[bot] commented 3 months ago

Commit 28f1a435a8b5b92205aa640d3fa8e2120de98815 has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 663 / PASS: 473 / FAIL: 187 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +28 / FAIL -67 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +35 / SKIP +0 / FAIL -35
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 228 / SKIP: 1 / FAIL: 59
github-actions[bot] commented 3 months ago

Commit d5a342305ec226621148576ec229fc5f31589ff5 has GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +35 / SKIP +0 / FAIL -35
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 228 / SKIP: 1 / FAIL: 59
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 663 / PASS: 473 / FAIL: 187 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +28 / FAIL -67 / ERROR +0 / SKIP +0
github-actions[bot] commented 3 months ago

Commit aba5c66820e51495f902b03454695f7669169c28 has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 659 / PASS: 477 / FAIL: 179 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +28 / FAIL -67 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +34 / SKIP +0 / FAIL -34
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 230 / SKIP: 1 / FAIL: 57
github-actions[bot] commented 3 months ago

Commit b194948682f4a6385fa129f3918f1be22eb37e1c has GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +34 / SKIP +0 / FAIL -34
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 230 / SKIP: 1 / FAIL: 57
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 659 / PASS: 477 / FAIL: 179 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +28 / FAIL -67 / ERROR +0 / SKIP +0
github-actions[bot] commented 3 months ago

Commit 7b97d749318b58f333b84b53a69ee2cda3eee863 has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test follow-basic.new-O3 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test posix-dflt.new-O2 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 659 / PASS: 477 / FAIL: 179 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +28 / FAIL -67 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +34 / SKIP +0 / FAIL -34
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 230 / SKIP: 1 / FAIL: 57
hanbings commented 3 months ago

Will there be more updates here? Should we merge it? Anyway this is a legendary PR, thanks! :)

tavianator commented 3 months ago

This should be good to go! Thanks