uutils / findutils

Rust implementation of findutils
MIT License
314 stars 38 forks source link

Implement `-fprintf` #444

Closed hanbings closed 2 months ago

hanbings commented 3 months ago

Closes #383

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.57%. Comparing base (4d36789) to head (6f64a19). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/find/matchers/mod.rs 44.44% 1 Missing and 4 partials :warning:
tests/find_cmd_tests.rs 92.30% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #444 +/- ## ========================================== + Coverage 66.53% 66.57% +0.03% ========================================== Files 36 36 Lines 4378 4404 +26 Branches 986 993 +7 ========================================== + Hits 2913 2932 +19 - Misses 1063 1064 +1 - Partials 402 408 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Commit b5853cb6c3106e0d63f5cf613a46a4a5885c4ade has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O3 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 694 / PASS: 449 / FAIL: 242 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL -4 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +1 / SKIP +0 / FAIL -1
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 197 / SKIP: 1 / FAIL: 90
sylvestre commented 3 months ago

needs rebasing

github-actions[bot] commented 3 months ago

Commit dc33ca5678a6782f12a2448c5beab724ed5b0b3d has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O3 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 655 / PASS: 477 / FAIL: 175 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL -4 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Congrats! The bfs test gnu/fprintf is now passing!
Run BFS tests: Congrats! The bfs test posix/exec_plus_status is now passing!
Run BFS tests: Changes from main: PASS +1 / SKIP +0 / FAIL -1
Run BFS tests: BFS tests summary = TOTAL: 317 / PASS: 242 / SKIP: 6 / FAIL: 69
github-actions[bot] commented 2 months ago

Commit 67eb6f54ac10a78d89072fbb64b9531b348a7b65 has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O3 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 655 / PASS: 477 / FAIL: 175 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL -4 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Congrats! The bfs test gnu/fprintf is now passing!
Run BFS tests: Changes from main: PASS +1 / SKIP +0 / FAIL -1
Run BFS tests: BFS tests summary = TOTAL: 317 / PASS: 242 / SKIP: 6 / FAIL: 69
github-actions[bot] commented 2 months ago

Commit 4ed3bc0e757c63d3a5273d90f6b58af793c52f89 has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O3 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 655 / PASS: 477 / FAIL: 175 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL -4 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Congrats! The bfs test common/L_ls is now passing!
Run BFS tests: Congrats! The bfs test common/ls is now passing!
Run BFS tests: Congrats! The bfs test gnu/fls is now passing!
Run BFS tests: Congrats! The bfs test gnu/fprintf is now passing!
Run BFS tests: Changes from main: PASS +4 / SKIP +0 / FAIL -4
Run BFS tests: BFS tests summary = TOTAL: 317 / PASS: 245 / SKIP: 6 / FAIL: 66
github-actions[bot] commented 2 months ago

Commit 07e9b1199f24dace33a1c6162b13681ab83eaa28 has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O3 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 655 / PASS: 477 / FAIL: 175 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL -4 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Congrats! The bfs test gnu/fprintf is now passing!
Run BFS tests: Changes from main: PASS +1 / SKIP +0 / FAIL -1
Run BFS tests: BFS tests summary = TOTAL: 317 / PASS: 245 / SKIP: 6 / FAIL: 66
github-actions[bot] commented 2 months ago

Commit 4130c38813de63ce3fcb66c245d51b9d78c30fee has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O3 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 651 / PASS: 481 / FAIL: 167 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL -4 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Congrats! The bfs test gnu/fprint0 is now passing!
Run BFS tests: Congrats! The bfs test gnu/fprintf is now passing!
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 317 / PASS: 246 / SKIP: 6 / FAIL: 65
sylvestre commented 2 months ago

Any idea why PASS +0 in ? Run GNU findutils tests: Changes from main: PASS +0 / FAIL -4 / ERROR +0 / SKIP +0

github-actions[bot] commented 2 months ago

Commit 6f64a19dcdeb5419759e8ddb62aaae62acf9f7da has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test fprintf-samefile.new-O3 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 651 / PASS: 481 / FAIL: 167 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL -4 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Congrats! The bfs test gnu/fprintf is now passing!
Run BFS tests: Changes from main: PASS +1 / SKIP +0 / FAIL -1
Run BFS tests: BFS tests summary = TOTAL: 317 / PASS: 246 / SKIP: 6 / FAIL: 65
hanbings commented 2 months ago

Any idea why PASS +0 in ? Run GNU findutils tests: Changes from main: PASS +0 / FAIL -4 / ERROR +0 / SKIP +0

I guess it's something to do with the total number of GNU tests changing? I haven't seen anything like this either, it seems to have been like this since the beginning of this PR. ¯\(ツ)

But at least we know the code works.

sylvestre commented 2 months ago

this version is good enough, thanks :)