search

uutils / platform-info

A cross-platform way to get information about your machine
MIT License
85 stars 25 forks source link

Fix build on Windows x86 #4

Closed Arcterus closed 6 years ago

Arcterus commented 6 years ago

Based on the fact it failed on both GNU and MSVC on x86, something is up. It may be because of using GetNativeSystemInfo() instead of GetSystemInfo().

Arcterus commented 6 years ago

The problem is actually the test. We shouldn’t be checking the target architecture in the test, but the architecture the binary is currently running on. What we are currently doing causes an issue when using WoW64, where the expected architecture is x86 and the actual architecture is x86_64.

Arcterus commented 6 years ago

Fixed by d8f497798725694c821cfe3a65cbd2c21d16762a.