search

uutils / util-linux

Rust reimplementation of the util-linux project
MIT License
17 stars 10 forks source link

lscpu: Add option --json #68

Open howjmay opened 3 months ago

howjmay commented 3 months ago

closes #15

sylvestre commented 3 months ago

please add tests to make sure we don't regress thanks

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 49.29%. Comparing base (cc93968) to head (fc7bf39). Report is 36 commits behind head on main.

Files Patch % Lines
src/uu/lscpu/src/lscpu.rs 78.57% 4 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #68 +/- ## ========================================== + Coverage 42.44% 49.29% +6.85% ========================================== Files 13 14 +1 Lines 1555 1641 +86 Branches 209 217 +8 ========================================== + Hits 660 809 +149 + Misses 868 793 -75 - Partials 27 39 +12 ``` | [Flag](https://app.codecov.io/gh/uutils/util-linux/pull/68/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uutils) | Coverage Δ | | |---|---|---| | [macos_latest](https://app.codecov.io/gh/uutils/util-linux/pull/68/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uutils) | `49.48% <82.35%> (+7.04%)` | :arrow_up: | | [ubuntu_latest](https://app.codecov.io/gh/uutils/util-linux/pull/68/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uutils) | `45.24% <82.35%> (+6.91%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uutils#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

howjmay commented 3 months ago

@sylvestre test added

howjmay commented 3 months ago

@sylvestre Anything I should improve to this PR?