search

uuvsimulator / uuv_simulator

Gazebo/ROS packages for underwater robotics simulation
https://uuvsimulator.github.io/
Other
699 stars 361 forks source link

uuv_descriptions: add xacro as a runtime dependency #362

Closed russkel closed 5 years ago

russkel commented 5 years ago

If xacro is not installed then it is not possible to spawn ROVs using upload_rexrov.launch.

musamarcusso commented 5 years ago

Hi @russkel, I think the builds are breaking because xacro was removed as test dependency.

russkel commented 5 years ago

@musamarcusso , sorry I am not very familiar with catkin package system. I pushed a new version.

musamarcusso commented 5 years ago

Thanks for the fix @russkel :D No need to apologize :) the thing is that when the checks with catkin_lint fail, the build might run but later on the ROS Buildfarm might show some errors. Thanks for the contribution!

russkel commented 5 years ago

Most welcome. I thought test dependencies would be a subset of exec_dependencies, but that doesn't seem to be the case.

This hopefully will fix the debian/ubuntu packages and install xacro as well?

musamarcusso commented 5 years ago

Yes, I think it will, I will set a new release and hopefully the package will be available via apt soon with the fixes

russkel commented 5 years ago

Okay sounds good!

I did notice this: https://index.ros.org/p/uuv_descriptions/github-uuvsimulator-uuv_simulator/#melodic-deps No dependencies are mentioned at all. ROS infrastructure bug?

musamarcusso commented 5 years ago

It seems like it does not consider anything listed as exec_depend for some reason. For uuv_gazebo_plugins it seems to list everything https://index.ros.org/p/uuv_gazebo_plugins/github-uuvsimulator-uuv_simulator/#melodic-deps

russkel commented 5 years ago

Raised an issue https://github.com/ros-infrastructure/rosindex/issues/155

Maybe it's intentional, maybe not.