search

uuvsimulator / uuv_simulator

Gazebo/ROS packages for underwater robotics simulation
https://uuvsimulator.github.io/
Other
675 stars 355 forks source link

Add Noetic support. Set compiler flags based on CMake version. Add co… #423

Closed tdenewiler closed 2 years ago

tdenewiler commented 3 years ago

…nditional code to support Gazebo 11.

Signed-off-by: Thomas Denewiler thomas.denewiler@navy.mil

lxuhill commented 3 years ago

@tdenewiler Could you give the steps of your installation process? I assume you're using Ubuntu 20.04?

tdenewiler commented 3 years ago

I am using Linux Mint 20, which is a nearly identical derivative of Ubuntu 20.04 (they share almost all the same apt repositories). I followed the ROS2 installation guide at https://index.ros.org/doc/ros2/Installation/Foxy/Linux-Install-Debians/, selecting the recommended options for all the steps. I have the UUV simulator packages/repositories built from source in a regular workspace under my home directory.

lxuhill commented 3 years ago

Thank you for the reply. So you are running uuv_simulator in Foxy (ROS2), not Noetic (ROS1)?

I'm trying to build and run uuv_simulator in Noetic and having dependency issues around uuv_control_utils, uuv_trajectory_control, and uuv_thrust_manager. How did you solve them in Foxy?

tdenewiler commented 3 years ago

My mistake, I apologize. I installed ROS Noetic using the default options: http://wiki.ros.org/noetic/Installation/Ubuntu. I used debs to install ROS, but have the UUV simulator/manipulator repositories and packages built from source with these custom branches.

I made a similar set of changes for Plankton to work on Ubuntu 20.04 with Foxy.

Can you describe the dependency issues you are having? Is it related to rosdep? If so, I have a separate pull request that makes dependency installation on Noetic easier: #419. Does that help?

lxuhill commented 3 years ago

Ah, thank you for the clarification, that seemed to fix my problems.

So I assume #419 needs to merged first?

tdenewiler commented 3 years ago

I think that #419 and #423 are independent, but #419 makes the packages more user-friendly and robust and allows for releases to be made. I would merge #419 first.