uuvsimulator / uuv_simulator

Gazebo/ROS packages for underwater robotics simulation
https://uuvsimulator.github.io/
Other
675 stars 355 forks source link

Corrected a typo in a variable name (claStall) of the LiftDragModel #427

Closed achille-martin closed 3 years ago

achille-martin commented 3 years ago

Dear UUV Sim Devs,

I was playing around with the Lift/Drag models for the fins and I realised a couple of things:

Concerning the two lines model and the Drag component, it is consistent to use the same "S" shaped graph for both the Lift coefficient CL=f(alpha) and the Drag coefficient CD=f(alpha), as described http://gazebosim.org/tutorials?tut=aerodynamics&cat=physics. When I refer to "S" shaped graph, I mean the Cl vs alpha graph like presented http://gazebosim.org/tutorials?tut=aerodynamics&cat=physics.

However, it is not physically correct to have a drag vector oriented along the inertial velocity of the sub when the alpha is negative: it should always be oriented opposite to the inertial velocity (as shown http://gazebosim.org/tutorials?tut=aerodynamics&cat=physics whatever the alpha value. Therefore I have updated the code to generate a "V" shaped two lines approximation for the drag component (as shown http://airfoiltools.com/airfoil/details?airfoil=naca0015-il, CD vs alpha).

Best regards,

Achille

achille-martin commented 3 years ago

Will create branches to enable discussions on both commits