search

uva-bi-sdad / sdc.metadata

https://uva-bi-sdad.github.io/sdc.metadata/
0 stars 0 forks source link

Statement formatting #7

Closed miserman closed 2 years ago

miserman commented 2 years ago

Two aspects to decide on for statement formatting:

  1. Should they end with periods? Most currently don't, but some do.
  2. Should type-specific notation (e.g., $, %, MB/s) be included in the statement, or handled in code?

I think periods make sense, and notation would best be handled in code so it can be (a) applied wherever the value appears and (b) potentially omitted on invalid values. Currently, invalid values all show as "unknown", but percent types still get a % -- we could change that in code and expand notated types, but can't as easily do that if the notation is in the statement.

There are also some extra spaces in some statements.

jo-schroeder commented 2 years ago

I'll clean up the periods and extra spaces. For the type-specific notation, I agree it should be handled in code. I'll start putting something together on what types we currently have.

jo-schroeder commented 2 years ago

Added these types:

I'm not sure what to do about the per 100,000 etc types, since right now we only have 2 and they are different populations (residents and Medicare enrollees), maybe there will be ideas when we figure out the catchment scores scaling

miserman commented 2 years ago

A general value formatter is now implemented with those types so far.