search

uva-cs / pdr

A repo for a Program and Data Representation university-level course
Other
91 stars 227 forks source link

Lab 11 traveling-skeleton.cpp: return 0 for computeDistance() #52

Closed adeet1 closed 4 years ago

adeet1 commented 4 years ago

This prevents compiler warning control reaches end of non-void function.

50Wliu commented 4 years ago

I'm actually afraid that this will confuse some people who will end up leaving this in because it was provided 😬

50Wliu commented 4 years ago

...though if this ends up confusing them, that probably indicates a bigger problem since it's lab 11... So yeah, this should be fine.

adeet1 commented 4 years ago

@50Wliu Yes, I made this pull request so that the provided code compiles out-of-the-box, with zero warnings. Also it's a good practice to have a method return a dummy value if it has not yet been implemented (students were suggested to do this for lab 2).