uvarc / ed-platform

Mobile friendly web app to sign up for local workshops hosted at the University of Virginia.
MIT License
0 stars 0 forks source link

Workshops creation/deletion without any user added #4

Open orkuva opened 6 years ago

orkuva commented 6 years ago

Workshops can be created without explicitly specifying a user (i.e. instructor). This causes a few CRUD issues. Two user tests were performed to confirm the existence of the bug:

Test 1 (No user added): Scenario: Title added, description added, discourse enabled, code added, session not added

Saving the workshop doesn't redirect to previous page, but a new workshop with the added details above does appear. Adding a session to this workshop creates two identical workshops under a code in the track homepage. One with a session added, and one without the session. Both are separate workshops.

Deleting the session deletes the extra workshop with the session. The remaining workshop cannot be deleted altogether.

Test 2 (User added) Scenario Title added, description added, discourse enabled, code added, session not added

Saving the workshop works fine, redirects as expected. Session addition/deletion works fine. Workshop doesn't duplicate under its code on the track page. Workshop deletion works fine.

Recommendation Changing "User Search" to "Instructor Search" and making the addition of Instructor mandatory to workshop creation, and creating a step-wise workflow using numbers before every section heading e.g. User Search -> Step 1: Add Instructor from search Workshop Details -> Step 2: Workshop Details Save this workshop -> Step 3: Save this workshop Add/Edit A Session -> (optional) Step 4: Add/Edit a Session