search

uvdesk / community-skeleton

UVdesk Opensource Community Helpdesk Project built for all to make a Full Ticketing Support System along with many more other features.
https://www.uvdesk.com
MIT License
8.53k stars 459 forks source link

Jquery update necessary but some issue to resolve in branding links page #311

Closed PeopleInside closed 3 years ago

PeopleInside commented 3 years ago

you will need update Jquery asap, now, tomorro, this week but never later. The only safer version is the latest one https://jquery.com/ 3.5.1

papnoisanjeev commented 3 years ago

@PeopleInside You can update Jquery and backbone latest version cdn link.

You just need to update it into layout:

Js backbone link

locate path: vendor/uvdesk/support-center-bundle/Resources/views/Templates/layout.html.twig vendor/uvdesk/core-framework/Resources/views/Templates/layout.html.twig

You can Update latest cdn link here.

PeopleInside commented 3 years ago

This has resolved all, many thanks !!!!!!!

PeopleInside commented 3 years ago

The update seems create an issue SharedScreenshot

right menu blocked, it never hide anymore.

I may need to revert changes.

PeopleInside commented 3 years ago

Sorry, resolved the menu issue, was a typo issue on my side.

papnoisanjeev commented 3 years ago

@PeopleInside

Please check your console it will show error if something is not correctly loaded.

Also as you will use latest version some functions may be depreciated in latest version which we have used in project may be due to this you are facing this issue.

PeopleInside commented 3 years ago

@PeopleInside

Please check your console it will show error if something is not correctly loaded.

Also as you will use latest version some functions may be depreciated in latest version which we have used in project may be due to this you are facing this issue.

Was a typo issue on my side. Fixed all works

papnoisanjeev commented 3 years ago

@PeopleInside

Sorry, resolved the menu issue, was a typo issue on my side.

Glad to know that your issue has been resolved.

PeopleInside commented 3 years ago

I'M opening this again because some issue should be fixed:

I created the necessary patch to update but an issue should be resolved in Branding Links that is broken after the updates. You need to test my patch on your side, the patch is correct but need maybe some update in the branding link page on the theme or other UVdesk file.

PeopleInside commented 3 years ago

The issue with my patch update is not only for the Branding link page but also Broadcast Message

PeopleInside commented 3 years ago

Hi, I found another issue that you can test directly in the test instance I created for you and you should know how to reach.

In particular in branding custom color button has the wrong color. This never happen always but with some combinations.

1 2 3

uvdesk color issue

papnoisanjeev commented 3 years ago

@PeopleInside

As we have change our brand color to https://prnt.sc/uxgl98 and it is getting reflected back for buttons in knowledgebase https://prnt.sc/uxguz7

Have you successfully saved the changes or due to jquery update it is not working for you?

PeopleInside commented 3 years ago

Hi, I tested with mine update. For some colour the buttons are correctly changed but for some else color maybe more light on more on the "right of the cube" where you select color, buttons loose the customisation.

You can try on the demo I set for you. You should know how to access as for the Skype support.

Sent from mobile​

Il giorno 12 ott 2020, 06:13, alle ore 06:13, sanjeev notifications@github.com ha scritto:

@PeopleInside

As we have change our brand color to https://prnt.sc/uxgl98 and it is getting reflected back for buttons in knowledgebase https://prnt.sc/uxguz7

Have you successfully saved the changes or due to jquery update it is not working for you?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/uvdesk/community-skeleton/issues/311#issuecomment-706847440

PeopleInside commented 3 years ago

I'm also unable to save time zone as the save button did not work with the update.

PeopleInside commented 3 years ago

SharedScreenshot

I'm trying to understand where the problem is in branding page where all are broken with the jQuery update but I'm not a programmer. Hope you will be able to find where the issue is just on Branding page, on all Branding tabs.

Once done the update should be done asap for users.

papnoisanjeev commented 3 years ago

@PeopleInside Please replace https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js this CDN link by old link https://ajax.googleapis.com/ajax/libs/jquery/2.2.4/jquery.min.js

Locate path: vendor/uvdesk/support-center-bundle/Resources/views/Templates/layout.html.twig vendor/uvdesk/core-framework/Resources/views/Templates/layout.html.twig

You need to update CDN link here.

As due to you have updated the latest Jquery link many jquery function (due to depreciation) not working. If we update latest link we need to make lots of changes in whole project.

PeopleInside commented 3 years ago

@PeopleInside Please replace https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js this CDN link by old link https://ajax.googleapis.com/ajax/libs/jquery/2.2.4/jquery.min.js

Locate path: vendor/uvdesk/support-center-bundle/Resources/views/Templates/layout.html.twig vendor/uvdesk/core-framework/Resources/views/Templates/layout.html.twig

You need to update CDN link here.

As due to you have updated the latest Jquery link many jquery function (due to depreciation) not working. If we update latest link we need to make lots of changes in whole project.

I will not do as this is a strong security issue. You should know what is a security issue and you should not suggest to have a vulnerability.

You will need do a lots of changes in the branding section. Other pages and sections seems work fine.

Do you want leave the project old and with security issues or you are telling me this will just only require time? And do you understand this should be priority on everything?

I'm confused on your reply.

If you have a security issue and you know about that I think you should be also responsible for all customer or user that use your software thinking is updated and supported so thinking is safe to use when you do not prioritize a fix.

PeopleInside commented 3 years ago

https://www.cvedetails.com/vulnerability-list/vendor_id-6538/product_id-11031/version_id-286394/Jquery-Jquery-2.2.4.html

PeopleInside commented 3 years ago

I hope your suggestion means:

if I need change some settings in branding than I can revert back and have the vulnerability for some minutes than after doing the changes I can re apply the patch.

You have a lot of code to change so fix will require some time but you will work on it. I hope the meaning of your reply is this.

papnoisanjeev commented 3 years ago

@PeopleInside

I hope your suggestion means: if I need change some settings in branding than I can revert back and have the vulnerability for some minutes than after doing the changes I can re apply the patch. You have a lot of code to change so fix will require some time but you will work on it. I hope the meaning of your reply is this.

Yes, this is what i mean.

PeopleInside commented 3 years ago

@papnoisanjeev ok -

PeopleInside commented 3 years ago

Thank you!