search

uvdesk / community-skeleton

UVdesk Opensource Community Helpdesk Project built for all to make a Full Ticketing Support System along with many more other features.
https://www.uvdesk.com
Open Software License 3.0
9.13k stars 464 forks source link

SMTP Special caracter cause fatal SMTP error #713

Open PeopleInside opened 11 months ago

PeopleInside commented 11 months ago

Bug report

Title

Email with a password that have special characters like @.!? will be not able to send email in UVdesk. The bad thing is that no error is showed when admin save the settings.

The error will occur only if a ticket is created or a notification need to be sent by email, no email will be sent.

Please add the support for special characters in email passwords! If this is already supported for IMAP incoming add support also for SMTP settings!

Issue Description

Recently I updated my email passwords for security and introduced special characters in passwords. I keep this config for months and then after different week login into the system let me discovered that a lot of ticket was created but no email notification was sent.

If an email has special characters in a password UVdesk will save the email config with a green message even if UVdesk are not able to use that password so will be not able to send email.

Preconditions

Please provide as detailed information about your environment as possible.

1. framework Version.  1.1.3
2. Commit id. don't know.

Steps to reproduce

It is important to provide a set of clear steps to reproduce this bug.If relevant please include code samples.

1. create an email for the helpdesk and se a password with special characters like @!?
2. configure that email as IMAP and SMTP
3. Try to create a ticket and you will receive error no email will be sent.

Expected result

Email working correctly

Actual result

If password of the email address has special characters, mail in UVdesk will not work.

PeopleInside commented 11 months ago

I'm asking why you don't do any check when save email credentials. Usually application check if they are able to connect to IMAP or SMTP and if something is wrong an error message is showed.

UVdesk never do any of this check, just save email settings, showing a green message even if credentials are wrong. This is bad.

Also UVdesk is the only app I know that create issues if special characters are in the password.

I hope you can fix this two things: add check on SwiftMailer and MailBox

And allow special password character that if is present now will broke UVdesk as email stop to work. https://github.com/uvdesk/mailbox-component/issues/109