uvdesk / mailbox-component

The Mailbox component provides tools that allows your helpdesk to process tickets from multiple email sources.
MIT License
22 stars 38 forks source link

Mailbox component doesn't extract inline image as attachment #80

Closed cney-afluens closed 2 years ago

cney-afluens commented 2 years ago

Description

The images embeded in email are posted as content and not extracted as attachment, this conducts to very large database and ends in uvdesk crashing when loading tickets.

How to reproduce

Send an email from Gmail with an inline image (not an attachment)

Possible Solution

Email content needs to be parsed and images removed or posted as attachment.

Additional context

vipin-shrivastava commented 2 years ago

@cney-afluens

Thank you & providing some more information regarding this issue. As we check with inline 15-20 images sent with Gmail in multiple replies of tickets but we didn't face any issue.

cney-afluens commented 2 years ago

Vipin,

You are using a parser option that embed images in messages. With big images this rapidly exhaust memory since everything is stored in database and called on every refresh.

Here is the patch

--- a/Services/MailboxService.php +++ b/Services/MailboxService.php @@ -344,7 +344,7 @@ class MailboxService // Process Mail - Content $htmlFilter = new HTMLFilter(); $mailData['subject'] = $parser->getHeader('subject');

Le mar. 19 oct. 2021 à 16:03, Vipin Shrivastava @.***> a écrit :

@cney-afluens https://github.com/cney-afluens

Thank you & provide some more information regarding this issue. As we check with inline 15-20 images sent with Gmail in multiple replies of tickets but we didn't face any issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uvdesk/mailbox-component/issues/80#issuecomment-946757224, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUNZOHD7YDS2BXUCZO3PCO3UHV3D5ANCNFSM5GIFRVJA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

cney-afluens commented 2 years ago

Please reopen this ticket

vipin-shrivastava commented 2 years ago

@cney-afluens

As we updated the code . it is showing message like this :

inline_image_error

cney-afluens commented 2 years ago

Yes, This is the expected behavior as we don"t store images in database. The next step we are working on is to keep the name of the file in the attachments. Then if you think it is important, we car work on using attachment url to embed the file in the message itself. cheers

Le jeu. 28 oct. 2021 à 14:58, Vipin Shrivastava @.***> a écrit :

@cney-afluens https://github.com/cney-afluens

As we updated the code . it is showing message like this :

[image: inline_image_error] https://user-images.githubusercontent.com/58874186/139259573-f6da3945-a4e5-4070-b87f-c3139886c9b7.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uvdesk/mailbox-component/issues/80#issuecomment-953818778, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUNZOHBSDHBYNB636GL6YALUJFCHVANCNFSM5GIFRVJA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

komal-sh-27 commented 2 years ago

@cney-afluens Now, this issue is solved with inline images attached from the email side

image

so we are closing this issue if you still facing the same issue so reply in the same thread.