search

uvdesk / support-center-bundle

Provide your customers with convenience by introducing the Support Center Portal to your UVDesk Community Helpdesk System.
https://www.uvdesk.com
MIT License
34 stars 30 forks source link

Throw NotFoundHttpException instead to render 404 Page Not Found error message when ticket is not found #166

Closed vipin-shrivastava closed 2 years ago

vipin-shrivastava commented 2 years ago

1. Why is this change necessary?

Page not found exception not working properly.

2. What does this change do, exactly?

add NotFoundHttpExeption in place of Excepton

3. Please link to the relevant issues (if any).

https://github.com/uvdesk/core-framework/issues/487

PeopleInside commented 2 years ago

@vipin-shrivastava I applied your patch and start to have issues https://github.com/uvdesk/community-skeleton/issues/520

PeopleInside commented 2 years ago

The issue seems to be not caused by this edit. I will wait UVdesk support to my ticket and to my issue, I need urgently fix this. Thanks

PeopleInside commented 2 years ago

@vipin-shrivastava I tested this and seems not a good fix. Once you apply the fix create a ticket from the web than try to open that ticket as customer: you will get 404 not found page so the fix is not working as with this fix ticket are no more visible to the user.

Reverting your pull request resolve the issue. Please test better.

2

Ticket list work but when click on existing ticket the ticket is not found.

1

Removing your pull request edit, the ticket loads correctly

3