uvicgse / project-virtual-team-3

0 stars 0 forks source link

No newline at end of file" notes are formatted improperly in the diff panel #1

Open omazhary opened 5 years ago

omazhary commented 5 years ago

Steps to reproduce:

Start application and log in / continue without log in. Open a local or remote repository. Modify the end of a file so that you get "No newline at end of file" in the diff panel. Observe that the line number is duplicated, and the +/- column shows a '<' (or '=') symbol instead. The new line note also spans more than one line. Actual behaviour: image

Expected behaviour:

The new line note should either be removed, or formatted on one line such that the line number does not get duplicated.

Suggestions:

There is currently already a check for the new line note (checking for line.origin()!=62 in git.ts), but this does not seem to work consistently, so you may just need to add a few more checks for other variations of the line. image