search

uw-cmg / StructOpt_modular

A flexible and modular Structure Optimization suite for combining experimental data with energy simulations to create atomic structures.
3 stars 5 forks source link

ENH: Add generation functions #11

Closed zhongnanxu closed 8 years ago

zhongnanxu commented 8 years ago

I was looking at the generation functions, and I'm going to rework it a little. Right now, there is no obvious way to implement other generation functions outside of adding to the generate in the common/generators/init.py I was thinking about making this a class and do class inheritance, but I thought it'd be better to just change the code on the individual level and have it dynamically call different generate functions.

I will work on this and tell you when I am done.

jjmaldonis commented 8 years ago

@zhongnanxu should we close this? I think it was finished in PR #35

zhongnanxu commented 8 years ago

Sure.